From 7ee00c1ae887703486d6ccc145b1791ab38898fd Mon Sep 17 00:00:00 2001 From: Alex Gonzalez Date: Fri, 3 Mar 2017 18:55:26 +0100 Subject: [PATCH] meta-digi-dey: recipes-connectivity: bluez5: Allow to override baudrate Reviewing the patches while updating the QCA firmware to a new release, I encountered this patch. On the original PR it says: "Do not use hcitattach to reconfigure the baudrate but set it directly in the Bluetooth FW file; this save us from some syncronism problems if we are not using HW flow control." Current spins of the module already use hw flow control. Also, not allowing hciattach to override the baudrate does not seem right to me. It would be enough with passing a 3M baudrate to hciattach to match the firmware default. Signed-off-by: Alex Gonzalez --- ...o-not-override-the-baudrate-in-the-N.patch | 36 ------------------- .../bluez/bluez5_5.41.bbappend | 1 - 2 files changed, 37 deletions(-) delete mode 100644 meta-digi-dey/recipes-connectivity/bluez/bluez5-5.41/ccimx6ul/0022-hciattach_rome-do-not-override-the-baudrate-in-the-N.patch diff --git a/meta-digi-dey/recipes-connectivity/bluez/bluez5-5.41/ccimx6ul/0022-hciattach_rome-do-not-override-the-baudrate-in-the-N.patch b/meta-digi-dey/recipes-connectivity/bluez/bluez5-5.41/ccimx6ul/0022-hciattach_rome-do-not-override-the-baudrate-in-the-N.patch deleted file mode 100644 index 9420aacfb..000000000 --- a/meta-digi-dey/recipes-connectivity/bluez/bluez5-5.41/ccimx6ul/0022-hciattach_rome-do-not-override-the-baudrate-in-the-N.patch +++ /dev/null @@ -1,36 +0,0 @@ -From: Isaac Hermida -Date: Fri, 30 Sep 2016 12:46:17 +0200 -Subject: [PATCH] hciattach_rome: do not override the baudrate in the NVM file - -Do not use hcitattach to override the NMV baudrate because we are -setting it directly in the firmware file. - -https://jira.digi.com/browse/DEL-3057 - -Signed-off-by: Isaac Hermida ---- - tools/hciattach_rome.c | 11 ++--------- - 1 file changed, 2 insertions(+), 9 deletions(-) - -diff --git a/tools/hciattach_rome.c b/tools/hciattach_rome.c -index 59bdc16e4e8f..4f0f8c82fa8d 100644 ---- a/tools/hciattach_rome.c -+++ b/tools/hciattach_rome.c -@@ -1903,15 +1903,8 @@ download: - } - fprintf(stderr, "%s: Download TLV file successfully \n", __FUNCTION__); - -- /* -- * Overriding the baud rate value in NVM file with the user -- * requested baud rate, since default baud rate in NVM file is 3M. -- */ -- err = rome_set_baudrate_req(fd, local_baud_rate, controller_baud_rate); -- if (err < 0) { -- fprintf(stderr, "%s: Baud rate change failed!\n", __FUNCTION__); -- goto error; -- } -+ /* Do not override the baudrate in the TLV file */ -+ fprintf(stderr, "%s: Skipping Override of baud rate!\n", __FUNCTION__); - - /* Perform HCI reset here*/ - err = rome_hci_reset_req(fd, local_baud_rate); diff --git a/meta-digi-dey/recipes-connectivity/bluez/bluez5_5.41.bbappend b/meta-digi-dey/recipes-connectivity/bluez/bluez5_5.41.bbappend index 6c249511f..c6edca2b5 100644 --- a/meta-digi-dey/recipes-connectivity/bluez/bluez5_5.41.bbappend +++ b/meta-digi-dey/recipes-connectivity/bluez/bluez5_5.41.bbappend @@ -28,7 +28,6 @@ SRC_URI_append_ccimx6ul = " \ file://0019-bluetooth-Fix-flow-control-operation.patch \ file://0020-Adding-MDM-specific-code-under-_PLATFORM_MDM_.patch \ file://0021-Bluetooth-Fix-static-analysis-issues.patch \ - file://0022-hciattach_rome-do-not-override-the-baudrate-in-the-N.patch \ " inherit update-rc.d